feat(optimizer): turn on logical rewrite for stream #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyufjh
reviewed
Mar 24, 2022
| @@ -64,8 +60,8 @@ | |||
| BatchProject { exprs: [Case(($0 = 1:Int32), 1:Int32::Decimal, ($0 = 2:Int32), 2:Int32::Decimal, Normalized(0.0):Decimal)], expr_alias: [ ] } | |||
| BatchScan { table: t, columns: [v1] } | |||
| stream_plan: | | |||
| StreamMaterialize { table_id: 0, column_order: [], column_id: [#0], pk_indices: [] } | |||
| StreamProject { exprs: [Case(($0 = 1:Int32), 1:Int32::Decimal, ($0 = 2:Int32), 2:Int32::Decimal, Normalized(0.0):Decimal)], expr_alias: [ ] } | |||
| StreamMaterialize { table_id: 0, column_order: [$1 ASC], column_id: [#0], pk_indices: [1] } | |||
There was a problem hiding this comment.
Maybe out of the scope of this PR. Is pk_indices redundant with column_order? In another words, is it guaranteed that column_order must contain all PK columns with same order?
There was a problem hiding this comment.
yes... we can refactor it later
There was a problem hiding this comment.
#1208 also needs to be refactored.
Above code should be rewritten as an assertion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
due to mistake when resolve conflict, #1185 lose this part.
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Checklist
Refer to a related PR or issue link (optional)